Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return QueryDescription on ElementFinder.ToString() #212

Merged

Conversation

max-brewer
Copy link
Contributor

@max-brewer max-brewer commented Dec 24, 2019

Currently Coypu makes nice error messages using the internal property QueryDescrption. It would be useful if this were available publicly so that it could be used when writing test error messages externally.

Would it be acceptable to override ToString to use this property on the base class?

(I'm asuming that this is an internal property to limit the API surface so that it doesn't need to be supported in future)

@obstar obstar merged commit 613a791 into featurist:master Apr 16, 2020
@max-brewer max-brewer deleted the toString-on-ElementFinder branch May 13, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants