Various chart improvements #33
Conversation
|
Hi there, nice work! I'm just bringing it up but there seem to be missing docs that someone can follow? The need to install the helm dependencies for example. Any chance you could add those and anything else you think is relevant to help people out? |
|
ok, the NATS configuration appears to not be working either... the nats.urls= property needs to be set to the urls of the NATs servers in each of the configuration files. This is what I'm getting at the moment: |
|
I shall take a look, I did have it running locally but I had my nats release in a separate release with the same values. |
- Switch to chart dependencies for nats and postgres. - Make chart able to co-exist in the same namespace as another release. - Add toggle functionality to each component. - Add edge service override for ingress. - Add checksums to allow automatic restarts on configuration update.
Looks like I forgot to change the default NATS host from NAME READY STATUS RESTARTS AGE
featurehub-dacha-5977cb6bdf-69jkg 1/1 Running 3 10m
featurehub-dacha-5977cb6bdf-6hbmx 1/1 Running 3 10m
featurehub-edge-57c4d969dd-4gbs8 1/1 Running 2 10m
featurehub-edge-57c4d969dd-sg7rg 1/1 Running 3 10m
featurehub-management-repository-567ff88dfd-wmph4 1/1 Running 3 10m
featurehub-nats-0 3/3 Running 0 10m
featurehub-nats-1 3/3 Running 0 10m
featurehub-nats-2 3/3 Running 0 10m
featurehub-nats-box-78587c4478-2t2vd 1/1 Running 0 10m
featurehub-postgresql-0 1/1 Running 0 10m |
|
Ok! I spent a bit of time with this tonight because I do want it in! The only remaining issue I found is that because the dacha service has been renamed to featurehub-dacha, the config in edge's configmap still points to the old name - so http://dacha - and it needs to be http://featurehub-dacha. Otherwise it works a treat! If you could please make that mod, I will merge it straight in, and thanks for your work! |
|
Ok, I will assume its ok if I make this change. |
|
@rvowles Ha, sorry. I've been out of action ill most of the week. I did plan on sorting it as soon as I got to my desk again. |
|
Hi @naphta , it's ok, it seemed a simple fix 🙂 however it has appeared to have broken the release process so I'll look at that today. |
Just came to this chart to use and it had a few missing bits and issues that I saw when I used so I just went ahead and forked and made the changes.
Essentially with the topology I was planning I wanted to be able to deploy dacha and edge separately, and I noticed that the chart worked against me when I wanted to run it as two releases in the same namespace. Whilst I was in there I put a few minor fixes in around naming, updating to a third party nats and postgresql chart (at least in theory with the right values it could be used in production then), and allowed the ingress to target a service name of choice for the edge backend.
Happy to make any changes if there's a desire to merge this.