Accelerate loading of large SGF #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Sep 30, 2020
xiaoyifang
pushed a commit
to xiaoyifang/lizzie
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #752 (comment)
Summary:
Lizzie sends play/undo commands to the engine even when it builds only internal game tree. Besides #752, this makes loading of large SGF too slow. The present PR stops these useless play/undo in SGF loading. Though this PR is not a "fix" of #752, it may be useful as acceleration of loading.