Fix #362: show best moves after --visit exhaustion #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some minor cosmecis improvements.
Moves are always outputed in order by leelaz, so this processing this info is redundent. Furthermore, summary lines do not include any order, so we can only rely on print order for these. This commit remove the order field, and remove the Comparable interface from MoveData.
With the new "summary parser", Lizzie will now properly show best moves even after exhaustion of the --visit visits.
|
@zsalch Would you have time for a review? |
|
@OlivierBlanvillain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new parser for what I've called "summary line". Leelaz will systematically output small summaries like the following once it reached the maximum number of visits specified with the
--visitflag:Parsing this data fixes #362.
This PR also setups JUnit and adds a few tests for the new regular expression.