-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lizzie cannot remember Panel -> GtpConsole detached window is checked #777
Comments
There are the following eight types of "panel display", but only "status" and "Toolbar" are memorized for changes, and others are not memorized. |
Gtp Panel display used to be default true (IIRC before 0.7x?) when print_comms config can still be set, but was turned off to speed up the loading, and again a toggle function is added, and it would be toggled on showing the Tuning initialization instead of just a long "Engine Loading" waiting. Also when the Gtp Concole window reopened, Lizzie still remembers its previous location and resizing, hence some of the information of the window is kept already. All the components are there to make it a full-on panel (maybe an additional flag? and make Gtp Console visible at the right moment). Sometimes I can trick it to "keep the window" when Lizzie was hanged, and I process killed it without normal exit, which I believe bypasses the toggle in some earlier version. The Panel UI with LizzieMain can have more improved layout management and make customization better and more intuitive. |
You can check Settings > Engine > Print Engine Log so that GTP console is opened at startup. I think Lizzie never remembers the visibility of GTP console in the current and the past versions. See also #778. |
I've applied these changes, now they are remembered via recording their flags in the persist file. And I might remember incorrectly about the GTP console visibility was retained in the past (maybe those times I just happened to have config with the Print Engine Log set to true, sometimes I used diff and edit them between various test builds with different config files) BTW, when I regenerated new config.txt and persist files with these fixes, checking Settings > Engine > Print Engine Log doesn't automatically open the GTP console at startup. It is now only controlled by settings in View > Panel. |
Toggle large winrate graph by center-click for #777 #779 This bug is ...
I'm curious about this statement by @kaorahi. |
@NTUST-MITLAB BTW, have you also experienced similar freezes as #777 (comment) ? @hope366 Does #779 really cause the hang-up? Have you tried the same operations sufficient times without #779? What are your settings (Panel UI, etc.) and operations? Can you read console outputs when Lizzie freezes? I mean both GTP console and Windows console (a.k.a. "command prompt") where you typed I would like to know any hints. |
Since Lizzie-v0.7.2 was released, I have started lizzie in countless numbers, v0.7.3 and v0.7.4, but I have never failed to start it except for a setting error. The screenshot below shows what happened when this bug occurred, but the GTP console and command prompt display looks the same as when it started normally.However, lizzie does not accept any operation. By the way, while testing for this bug, I ran into another first-time bug. Below is a screenshot. The GTP console was set to show, but it doesn't seem to show due to this bug. The error statements displayed on the command prompt are actually much larger. Every time I grabbed lizzie with the mouse and moved it, it seemed that a lot of similar displays were added. |
Thanks for the report! It gave me useful hints. Something will be wrong about EDT. I'll try to debug it. |
@hope366, would you show the line 245 in your BoardRenderer.java? I guess it is this.
|
ok, this makes sense that the event log and console window are controlled independently.
Not actually, at least not failed to start. I've applied to #780 to this point, but also one of my own "fix" (the reversion of 6a339f0, but it shouldn't affect anything else, but just an extra drawstring). I did notice something after 0.7.3, that it sometimes lagged or temporarily froze and doesn't refresh the mainboard immediately using right-click and left-click to navigate the Variation Tree, but it worked fine and reacted immediately if the mouse clicked on the mainboard. Not sure what caused it and it only occurred occasionally. |
Would you try https://github.com/kaorahi/lizzie/tree/for777_EDT (a628068)? It may or may not fix the hang-up. |
I tried |
#777 (comment)Thank you for creating a PR to solve this. |
Normally I'd detached the Gtp Console so it can be resized and moved to a convenient location as a separate window.
After updating to 0.7.4, Lizzie cannot remember it has been opened, and have to check View -> Panel -> Gtp -> GtpConsole (or use hotkey alt+E) every time opening Lizzie.
The text was updated successfully, but these errors were encountered: