-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
express: use service.methods #945
Conversation
@daffl I resolved the conflict with master. |
Thank you. I think we might want to wait merging this (or making new changes in general) until the monorepo migration if finished and the latest version of everything has been published. |
@daffl I merged master and all the tests seem to pass. |
So the difficulty with this one is that we can't force the dependent Feathers version unless it is a major (breaking) change. If someone has e.g. |
|
I think so, too. Ok, I'll get this in with auth v3 (since authentication Express middleware will move here, too). It's going pretty well so it hopefully shouldn't be too long until a pre-release. |
…o express-handler
…express-handler
Please don't forget this for 4.0 |
Apply feathersjs-ecosystem/express#29
.diff