Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express: use service.methods #945

Merged
merged 19 commits into from
Apr 22, 2019
Merged

express: use service.methods #945

merged 19 commits into from
Apr 22, 2019

Conversation

bertho-zero
Copy link
Collaborator

@bertho-zero bertho-zero commented Aug 22, 2018

@bertho-zero bertho-zero changed the title Apply feathersjs/express#29 PR express: use service.methods Aug 22, 2018
@bertho-zero bertho-zero requested a review from daffl August 22, 2018 18:23
@bertho-zero
Copy link
Collaborator Author

@daffl I resolved the conflict with master.

@daffl
Copy link
Member

daffl commented Aug 23, 2018

Thank you. I think we might want to wait merging this (or making new changes in general) until the monorepo migration if finished and the latest version of everything has been published.

@bertho-zero
Copy link
Collaborator Author

@daffl I merged master and all the tests seem to pass.

@daffl
Copy link
Member

daffl commented Sep 17, 2018

So the difficulty with this one is that we can't force the dependent Feathers version unless it is a major (breaking) change. If someone has e.g. @feathersjs/feathers@3.1.x things will break (already seeing some issues around that, e.g. in #1000).

@bertho-zero
Copy link
Collaborator Author

@feathersjs/express probably requires a major version.

@daffl
Copy link
Member

daffl commented Sep 17, 2018

I think so, too. Ok, I'll get this in with auth v3 (since authentication Express middleware will move here, too). It's going pretty well so it hopefully shouldn't be too long until a pre-release.

@Mairu
Copy link
Contributor

Mairu commented Apr 22, 2019

Please don't forget this for 4.0

@daffl daffl merged commit 3f0b1c3 into feathersjs:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants