Fix duplicate events in dynamic services.

[marshallswain]

After fixing setup() for dynamic services in the last PR (#110), the events mixin's setup() function was adding duplicate events. This PR wraps applyEvents with an if (!this._serviceEvents) { ... } check to assure it isn't adding events twice.

[daffl]

Are you sure this is the best solution? I would think we just don't need to call applyEvents anymore since it will be mixed in and called with .setup, no?

[marshallswain]

Alternatively we can remove applyEvents and move this line: https://github.com/feathersjs/feathers/blob/master/lib/application.js#L54
just before this.addService() (a few lines up).

You think that's a better solution?

[daffl]

You could just update this PR by pushing to the fix-duplicate-events branch again instead of opening a new one. Or was there a reason?

[marshallswain]

Just so you could see the diff. Not trying to insult your intelligence. :)

[marshallswain]

I was thinking of leaving it the other way in preparation for allowing providers to be registered at any time and making a single pathway for registering services instead of the duality going on right now with setup() and addService(). It's not that big of a change though, so it doesn't really matter.

[daffl]

I will have another look. I feel that there there is a good single way of doing this. Maybe you are right and mixins are not the way to go here.

[daffl]

I did some refactoring in https://github.com/feathersjs/feathers/blob/ffb603a4d8be2b309f26ad2e449611f8f94f9993/lib/providers/socket/commons.js that should handle both kinds of services properly and also made the socket handlers a little shorter and moved the dynamic service tests into nested describes. Can you double check if that solves all the issues and also makes sense?

[marshallswain]

Ahh... Yes. That is so much cleaner and solves the issue.