Config path from package.json #1075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- try to use the NODE_CONFIG_DIRECTORY env variable - use 'config/' as default
jraut
force-pushed
the
feat/config-path-from-package.json
branch
2 times, most recently
from
81cba82 to
01cefc2
Compare
jraut
force-pushed
the
feat/config-path-from-package.json
branch
from
01cefc2 to
b0f6be1
Compare
|
Closing the pull request as the CLI and generators have been to their own repository. |
|
Hm, sorry about that, I've been meaning to backport this into https://github.com/feathersjs/generator-feathers next week. |
|
All right! Let me open this in generator-feathers if the proposed functionality could provide useful. There were issues with running tests so I was a bit unconfident about the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is created because of #987
It lets the CLI use a custom config folder.
Based on the discussions on the issue, the following changes were made to generating a new project
NODE_CONFIG_DIRenv variable since it is used by defaultconfig/(the current hardcoded value)Generator uses this new customizable value. It falls back to
config/on run time to maintain backwards compatibility.Thanks for a great framework and happy Hactober!