Request without Content-Type application/json have empty body

[Glavin001]

Request without Content-Type application/json have empty body.

I am using Postman REST Client and neglected to set the Content-Type to application/json which resulted in the body not being parsed by express.json and it was passing data = {} into my services' create handler.

I suggest that, since JSON is the notation being used for serialization with Feathers, that if the Content-Type is blank, it should default to application/json.

[Glavin001]

See http://stackoverflow.com/a/17228529/2578205 for solution implementation.

[daffl]

So technically you could add your own responder using res.format with app.configure(feathers.rest({ responder: function(req, res, next) })). I think the text formatter is the default one (which should also work for empty content types). The problem is, that it is already preconfigured since REST is initialized by default. I don't think we should turn that default behaviour off. Maybe allow to change it by setting app.rest.responder?

[daffl]

#52 should fix it by allowing to set up the REST provider later. This is the test I added to test it:

it('Lets you configure your own middleware before the handler (#40)', function(done) {
    var data = { description: 'Do dishes!', id: 'dishes' };
    var app = feathers({ rest: false });

    app.use(function defaultContentTypeMiddleware (req, res, next) {
      req.headers['content-type'] = req.headers['content-type'] || 'application/json';
      next();
    })
    .use(feathers.urlencoded())
    .use(feathers.json())
    .configure(feathers.rest())
    .use('/todo', {
      create: function (data, params, callback) {
        callback(null, data);
      }
    });

    var server = app.listen(4775);
    request({
      method: 'POST',
      url: 'http://localhost:4775/todo',
      headers: { 'Content-Type': 'application/json' },
      body: JSON.stringify(data)
    }, function (error, response, body) {
      assert.deepEqual(JSON.parse(body), data);
      server.close(done);
    });
  });

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.