Make sure .setup() runs on dynamic services. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daffl Does this look ready to merge? |
| socket.on('tasks removed', function (data) { | ||
| service.removed = oldRemoved; | ||
| assert.equal(data.id, 23); | ||
| done(); | ||
| console.log('Ready: ' + ready); |
|
Yes, after you remove the |
marshallswain
force-pushed
the
fix-setup
branch
from
dbce3b6 to
78dbec3
Compare
|
Wow. squash is new for me. That was a beautiful experience. |
marshallswain
added a commit
that referenced
this pull request
Feb 13, 2015
Make sure .setup() runs on dynamic services.
daffl
added a commit
that referenced
this pull request
Aug 21, 2018
daffl
added a commit
that referenced
this pull request
Aug 22, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 24, 2018
daffl
added a commit
that referenced
this pull request
Aug 25, 2018
Fix generated app tests for latest packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup() wasn't being run on dynamic services. I've included a fix and updated one of the tests to make sure setup runs.
Oh, I also moved
stripSlashes(location)to the top of app.service() and replaced all duplicate instances of it withlocation.