fix(generators): Harden mongodb.js to reliably extract database from …

…any connection string (#3264)
feathersjs · Jan 5, 2024 · 7b0f82c · 7b0f82c
1 parent 210f103
commit 7b0f82c
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/generators/src/connection/templates/mongodb.tpl.ts b/packages/generators/src/connection/templates/mongodb.tpl.ts
@@ -17,10 +17,14 @@ declare module './declarations' {
 
 export const ${database} = (app: Application) => {
   const connection = app.get('${database}') as string
-  const database = new URL(connection).pathname.substring(1)
-  const mongoClient = MongoClient.connect(connection)
-    .then(client => client.db(database))
+  
+  const databaseRegex = /\/([a-zA-Z0-9_\\-]+)(?:\?|$)/;
 
+  const databaseName = databaseRegex.exec(connection)?.[1];
+  
+  const mongoClient = MongoClient.connect(connection)
+    .then(client => client.db(databaseName));
+    
   app.set('${database}Client', mongoClient)
 }
 `