Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete app.configure(feathers.errors()) #30

Merged
merged 1 commit into from
Dec 21, 2015

Conversation

AminBK
Copy link
Contributor

@AminBK AminBK commented Dec 18, 2015

In Readme.md file there is no "app.configure(feathers.error())
but in examples/basic.js there is such call.

Was getting below error:

app.configure(feathers.errors());
^

TypeError: feathers.errors is not a function
at Object. (C:\gitProject\feathers-mongoose\examples\basic.js:22:25)
at Module._compile (module.js:398:26)
at Object.Module._extensions..js (module.js:405:10)
at Module.load (module.js:344:32)
at Function.Module._load (module.js:301:12)
at Function.Module.runMain (module.js:430:10)
at startup (node.js:141:18)

at node.js:980:3

in Readme.md

// Connect to the db, create and register a Feathers service.
app.use('todos', new mongooseService('todo', Todo));

// Start the server.

var port = 8080;

@ekryski
Copy link
Member

ekryski commented Dec 21, 2015

Thanks for the PR @verdeairo!

This might be a result of our new updates to feathers-errors. It should've been backwards compatible but I might have broken it. 😦

Regardless, I'll merge this simply so that the basic example runs right away.

With that said we have a new overhauled version of feathers-mongoose coming out pretty quick here so this PR will be irrelevant soon. 😄

ekryski added a commit that referenced this pull request Dec 21, 2015
delete app.configure(feathers.errors())
@ekryski ekryski merged commit 8b274ca into feathersjs-ecosystem:master Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants