You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The readme displays the use of a mongoose-service option "name" in the code example "Complete Example". The option and corresponding service property appear to have been deprecated with 210ccc8:
Excerpt from Complete Example in the readme:
// Connect to the db, create and register a Feathers service.app.use('messages',service({name: 'message',Model: Message,paginate: {default: 2,max: 4}}));
I don't know what this option or the corresponding service property have originally been used for, but to me it seems they are not in use anymore, so I suggest changing the line of the readme. If I am not misreading the service.js and it is not the intention to add back the option in an upcoming release I can create a pull request.
Edit: Okay I just created a PR for this, because the name option does not seem to do anything in the current release.
The text was updated successfully, but these errors were encountered:
githugger
pushed a commit
to githugger/feathers-mongoose
that referenced
this issue
Jul 6, 2016
The readme displays the use of a mongoose-service option "name" in the code example "Complete Example". The option and corresponding service property appear to have been deprecated with 210ccc8:
Excerpt from Complete Example in the readme:
Excerpt from service.js:
I don't know what this option or the corresponding service property have originally been used for, but to me it seems they are not in use anymore, so I suggest changing the line of the readme. If I am not misreading the service.js and it is not the intention to add back the option in an upcoming release I can create a pull request.
Edit: Okay I just created a PR for this, because the name option does not seem to do anything in the current release.
The text was updated successfully, but these errors were encountered: