Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change check for external provider as per daffl in disallow.js by 104c1b1 #565

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Change check for external provider as per daffl in disallow.js by 104c1b1 #565

merged 1 commit into from
Jan 23, 2020

Conversation

jalbersdorfer
Copy link
Contributor

Change check for external provider as per daffl in disallow.js by 104c1b1

Summary

fixes a 'undefined' to 'boolean' cast flaw in the same way it was already done before for the disallow hook.

@jalbersdorfer jalbersdorfer requested a review from daffl January 23, 2020 11:28
@daffl daffl merged commit 553c694 into feathersjs-ecosystem:master Jan 23, 2020
@daffl
Copy link
Member

daffl commented Jan 23, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daffl daffl Awaiting requested review from daffl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalbersdorfer @daffl