New softDelete for Feathers 4 #544
Merged
+216
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work @daffl... Been waiting for this... when this gonna be released and available? |
|
The only question I had was "why would
|
|
Great... But the docs have not yet been updated i guess, they still shows |
Merged
|
This is now available as v5.0.x. New softDelete (and other v5) documentation at https://hooks-common.feathersjs.com/hooks.html#softdelete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
softDeletehook that works with the adapter changes in Feathers 4. It is more performant because it no longer needs to make additional calls can can be fully customized by dynamically creating the query for removed items and the data when it gets deleted.softDelete2is now deprecated so related issues will be closed: