-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing the failing test case test_sql_registry.py on Mac environment. #4129
Closed
lokeshrangineni
wants to merge
7
commits into
feast-dev:master
from
lokeshrangineni:feature/fixing-mysql-test-container
Closed
fix: Fixing the failing test case test_sql_registry.py on Mac environment. #4129
lokeshrangineni
wants to merge
7
commits into
feast-dev:master
from
lokeshrangineni:feature/fixing-mysql-test-container
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
lokeshrangineni
changed the title
Fixing the failing test case test_sql_registry.py on Mac environment.
fix: Fixing the failing test case test_sql_registry.py on Mac environment.
Apr 23, 2024
…x the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
…x the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
…#4126) * chore: Move feast install to docker build in java it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove commented out lines in compose file Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * make local compose mode default Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * limit COPY contents Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove requirements.txt from java tests docker image Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * include pyproject.toml in dockerfile Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change links to depends_on Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * try updating setup-python to v5 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * pin macos image to macos-12 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * force rerun Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
* chore(release): release 0.37.1 ## [0.37.1](feast-dev/feast@v0.37.0...v0.37.1) (2024-04-17) ### Bug Fixes * Pgvector patch ([feast-dev#4108](feast-dev#4108)) ([1a1f0b1](feast-dev@1a1f0b1)) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([feast-dev#4112](feast-dev#4112)) ([d5ded69](feast-dev@d5ded69)), closes [feast-dev#3953](feast-dev#3953) * chore: Move feast install to docker build in java it tests (feast-dev#4126) * chore: Move feast install to docker build in java it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove commented out lines in compose file Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * make local compose mode default Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * limit COPY contents Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove requirements.txt from java tests docker image Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * include pyproject.toml in dockerfile Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change links to depends_on Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * try updating setup-python to v5 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * pin macos image to macos-12 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * force rerun Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Co-authored-by: feast-ci-bot <feast-ci-bot@willem.co> Co-authored-by: Tornike Gurgenidze <togurg14@freeuni.edu.ge>
…st reliable way rather than spoofing logs. Enabled the test cases in github actions with this code change hope it works. Trying to fix the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Trying to fix the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #4128.