Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add authentication option for snowflake connector #3039

Merged
merged 1 commit into from
Aug 10, 2022
Merged

feat: Add authentication option for snowflake connector #3039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel):
schema_: Optional[str] = Field(None, alias="schema")
""" Snowflake schema name """

authenticator: Optional[str] = None
""" Snowflake authenticator name """

storage_integration_name: Optional[str] = None
""" Storage integration name in snowflake """

Expand Down
6 changes: 5 additions & 1 deletion sdk/python/feast/infra/offline_stores/snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ class SavedDatasetSnowflakeStorage(SavedDatasetStorage):

def __init__(self, table_ref: str):
self.snowflake_options = SnowflakeOptions(
database=None, schema=None, table=table_ref, query=None, warehouse=None
database=None,
schema=None,
table=table_ref,
query=None,
warehouse=None,
)

@staticmethod
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/feast/infra/online_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ class SnowflakeOnlineStoreConfig(FeastConfigBaseModel):
schema_: Optional[str] = Field("PUBLIC", alias="schema")
""" Snowflake schema name """

authenticator: Optional[str] = None
""" Snowflake authenticator name """

class Config:
allow_population_by_field_name = True

Expand Down
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:

try:
conn = snowflake.connector.connect(
application="feast", autocommit=autocommit, **kwargs
application="feast",
autocommit=autocommit,
**kwargs,
)

return conn
Expand Down