chore: Implement to_remote_storage for supported offline stores #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
achals
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
===========================================
- Coverage 80.60% 59.45% -21.16%
===========================================
Files 179 179
Lines 15801 15870 +69
===========================================
- Hits 12737 9435 -3302
- Misses 3064 6435 +3371
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
achals
changed the title
achals
changed the title
: Signed-off-by: Achal Shah <achals@gmail.com>
sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following up to #2916 and #2901 by implementing the to_remote_storage methods for Redshift, Snowflake and BigQuery.
The implementation utilizes the native export/unload/copy into functionality present in each of the individual DWHs. There's more configuration possible (such as max file size) but I'm not going to add it into the config just yet.
In fact, a related thought I had is that it would be good to have a way to pass in configuration information (somehow) without needing to make code changes into the config classes.
Which issue(s) this PR fixes:
Fixes #