-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feast Core: Stage files manually when launching Dataflow jobs #291
Feast Core: Stage files manually when launching Dataflow jobs #291
Conversation
To resolve error: IllegalArgumentException: Unable to convert url When launching Dataflow jobs in Feast Core
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java
Outdated
Show resolved
Hide resolved
/hold
Reference: |
…flow - Unpack the jar created by Spring Boot - Set the classes and jars in BOOT-INF folder as the resources to stage
New approach that unpack the packaged jar and stage the files manually when trying to submit Dataflow jobs from Feast Core seems to work. But the As a comparison, using |
Current workaround for the slow unpacking of jar when running Feast in production: |
/hold cancel |
/lgtm |
/retest |
To resolve error when launching Dataflow jobs from Feast Core:
When Feast Core starts from a packaged jar.
Reference:
https://stackoverflow.com/questions/48961440/illegalargumentexception-unable-to-convert-url-jarfile-app-jar-boot-inf-cla
https://stackoverflow.com/questions/48292491/java-dataflow-unable-to-use-classloader-to-detect-classpath-elements