-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix ODFV decorator #2527
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
===========================================
- Coverage 81.99% 57.57% -24.42%
===========================================
Files 140 139 -1
Lines 11745 11660 -85
===========================================
- Hits 9630 6713 -2917
- Misses 2115 4947 +2832
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: #2514 switched from using
Feature
toField
for declaring types of features inFeatureView
s andOnDemandFeatureView
s. It left aTODO
to make the same change for the ODFV decorator; this PR completes that TODO. It also ensures that a previous change, #2442, does not break users using the ODFV decorator. It also enforces the usage of kwargs for the ODFV decorator.Which issue(s) this PR fixes:
Fixes #