Merge pull request #3 from gojektech/empty_result_handling

Empty response handling in serving api
feast-dev · Dec 13, 2018 · 1b1bd2b · 1b1bd2b
2 parents f15a6a7 + ee7fd87
commit 1b1bd2b
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java b/serving/src/main/java/feast/serving/grpc/ServingGrpcService.java
@@ -77,14 +77,6 @@ public void queryFeatures(Request request, StreamObserver<Response> responseObse
       Request validRequest = checkTimestampRange(request);
       Response response = feast.queryFeatures(validRequest);
 
-      if (response.getEntitiesCount() < 1) {
-        responseObserver.onError(
-            new StatusRuntimeException(
-                Status.fromCode(NOT_FOUND)
-                    .withDescription("No value is found for the requested feature")));
-        return;
-      }
-
       innerSpan.log("calling onNext");
       responseObserver.onNext(response);
       innerSpan.log("calling onCompleted");