Skip to content
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.

Bump crossterm to 0.26 with CI fix #689

Closed
wants to merge 4 commits into from
Closed

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jan 31, 2023

Description

Testing guidelines

I checked all examples by cargo run --example {example-name} and confirmed they work on iTerm2 on my Mac machine.

Checklist

  • I have read the contributing guidelines.
  • I have added relevant tests. (Since this PR just upgrading existing dependency, no tests need to be added)
  • I have documented all new additions.

Description

crossterm v0.26.0 was released recently. And some people are starting to use the latest version. Since this crate requires crossterm 0.25, both 0.25 and 0.26 are mixed in user's project when the user depends on crossterm directly. I actually saw an issue around this in my tui-textarea project: rhysd/tui-textarea#9

The best way to solve the issue is to follow the latest crossterm version by tui crate. I checked the release note and tui crate. Breaking changes seem not relevant to tui crate.

This is a breaking change due to MSRV bump from 1.56 to 1.58. crossterm 0.26 is using inline format arguments feature and it requires 1.58.

@rhysd rhysd force-pushed the crossterm-0.26 branch 4 times, most recently from 7b79943 to c0306dc Compare January 31, 2023 07:53
@rhysd rhysd changed the title Bump crossterm to 0.26 Bump crossterm to 0.26 with CI fix Jan 31, 2023
@rhysd
Copy link
Contributor Author

rhysd commented Jan 31, 2023

I fixed CI as well:

  • Fix installing cargo-make requires higher Rust version
  • Fix all clippy warnings with the latest stable toolchain

@rhysd
Copy link
Contributor Author

rhysd commented Jan 31, 2023

I think the Actions settings for this repository also need to be updated. The Linux (1.56.1) and Windows (1.56.1) workflows are required to be passed, but they don't exist.

@rhysd rhysd mentioned this pull request Jan 31, 2023
@rhysd
Copy link
Contributor Author

rhysd commented Feb 10, 2023

Rust 1.67.1 cancelled enabling uninlined_format_args lint rule which was once enabled by default at 1.67.0. So I created a commit to fix clippy warnings again at 06fba01.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants