-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade prost crates to 0.13 #68
Conversation
@fdeantoni Don't intend to pressure you - just wanted to let you know this PR exists and ask whether there's anything else I need to do as part of this change (e.g. CHANGELOG entry). Thanks! |
Many thanks for putting this PR together! I will review and if all looks good will try to create a new release in the next few days. |
no pressure |
@fdeantoni friendly ping? Would be nice to get this released! |
Hi all, apologies for the delay! I will make sure to push out an update this weekend. |
Should this be 0.6 release? Seems like updating the prost to 0.13 is breaking builds.
|
Yup, this should definitely get a semver-incompatible release (and you probably want to yank 0.5.2). |
Were all the dependencies updated to Prost 0.13 and prost-wkt to 0.5.2? Although Prost has gone to 0.13, the implementation of prost-wkt has not changed significantly, hence I kept it at 0.5. I realize now that this may cause problems and it should go to 0.6. I will yank this release and make it 0.6.0 instead. Apologies for all the trouble caused! |
Hi All, I have yanked 0.5.2 and released it as 0.6.0 instead. I've added a |
prost-wkt-build needs to be yanked as well
|
Apologies yes, |
All good now, Thank you. |
Upgrade to the latest
prost
version (0.13
):Closes #67