Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upgrade-utils output OCFL v1.1 #56

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

whikloj
Copy link
Contributor

@whikloj whikloj commented Nov 17, 2023

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3915

What does this Pull Request do?

Upgrades the versions of ocfl-java and fcrepo-storage-ocfl being used. Also updates the expected test objects to use the ocfl 1.1 style.

I hard-coded the Upgrade on Write to true, not sure if we want that to be optional?

How should this be tested?

Run over a Fedora 4 or 5 repository and see that OCFL 1.1 comes out. There were no functional changes so this is mostly a PR of updating test objects.

Additional Notes:

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

Interested parties

Tag (@ mention) interested parties or, if unsure, @fcrepo-exts/committers

@mikejritter mikejritter self-assigned this Nov 28, 2023
@mikejritter
Copy link
Contributor

I hard-coded the Upgrade on Write to true, not sure if we want that to be optional?

Sounds reasonable, I'm not sure there would be a use case for not upgrading since this would be making your ocfl for F6. I'm going to double check migration-utils then will test; at a glance this seems ok.

Copy link
Contributor

@mikejritter mikejritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works as expected. Feel like we'll want to update migration-utils as well to specify the ocfl version and upgrade objects on write.

@mikejritter mikejritter merged commit 32d5dc7 into fcrepo-exts:main Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants