Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge doesn't support numeric column names #2

Closed
fburic opened this issue Jan 2, 2024 · 1 comment
Closed

merge doesn't support numeric column names #2

fburic opened this issue Jan 2, 2024 · 1 comment
Assignees
@fburic
Labels
bug Something isn't working

Comments

@fburic
Copy link
Owner

fburic commented Jan 2, 2024 •
edited
Loading

grove.merge() and grove.Collection.merge() fail with GroveError: Specification of merge columns not supported if the on argument (the column name on which to join) is numeric.

Example:

    df1 = pd.DataFrame(
        [('a', 1),
         ['b', 2]]
    )
    df2 = pd.DataFrame(
        [('x', 1),
         ['b', 3]]
    )
    result = grove.merge(df1, df2, on=0)

yields

GroveError: Specification of merge columns not supported: 0
@fburic fburic added the bug Something isn't working label Jan 2, 2024
@fburic fburic self-assigned this Jan 2, 2024
@fburic fburic changed the title merge doesn't support numerical column names merge doesn't support numeric column names Jan 2, 2024
fburic added a commit that referenced this issue Jan 2, 2024
@fburic
fix: Issue #2 Add support for merge on columns with numeric ID
cceea61
@fburic
Copy link
Owner Author

fburic commented Jan 2, 2024

Fixed in version 0.1.4 (commit cceea61)

@fburic fburic closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fburic fburic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fburic