Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

feat: add VSCode dev container config and update Rocket to 0.4.5 #1

Merged
merged 3 commits into from
Sep 8, 2020
Merged

feat: add VSCode dev container config and update Rocket to 0.4.5 #1

merged 3 commits into from
Sep 8, 2020

Conversation

madyanalj
Copy link
Contributor

This PR:

  • updates Rocket as it was broken with the latest nightly build. The error mentioned in this issue kept appearing with the older version.
  • adds a config file to auto-setup Rust and relevant extensions out-of-the-box using VSCode's dev container setup (and in the future Codespaces). It is based on the official config file provided by Microsoft for Rust dev containers. See the new README section for more information.

English isn't my first language, but I tried my best to simplify the new doc section and add links for more information. I'd really appreciate your feedback :)

@facebook-github-bot
Copy link

Hi @madyanalj!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2020
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jsjoeio jsjoeio merged commit fe2bb75 into fbsamples:master Sep 8, 2020
@jsjoeio
Copy link

jsjoeio commented Sep 8, 2020

This is fantastic. All looks great. Thanks so much for adding that as an option @madyanalj ! 😄 We really appreciate it!

@madyanalj
Copy link
Contributor Author

This is fantastic. All looks great. Thanks so much for adding that as an option @madyanalj ! 😄 We really appreciate it!

No worries man! Thanks for reviewing and merging 🙇

@madyanalj madyanalj deleted the feature/AddDevContainer branch September 8, 2020 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants