Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Removed MessageReaction #369

Closed
wants to merge 2 commits into from
Closed

WIP: Removed MessageReaction #369

wants to merge 2 commits into from

Conversation

Demindiro
Copy link

It doesn't serve any purpose anymore since any emoji can be used apparently.

Closes #368

David Hoppenbrouwers added 2 commits December 12, 2018 13:18
It doesn't serve any purpose anymore since any emoji can be used apparently.
@Demindiro
Copy link
Author

Okay, so I can react with one of the 'classic' emojis but I can't react with a custom one (no error though)...

@kapi2289
Copy link
Contributor

You can't remove this model. It's a huge breaking change, that will break the code for many pepole, maybe just wrap in try the part that is making enum MessageReaction in fetchThreadMessages and on except return new enum value MessageReaction.UNDEFINED?

@Demindiro Demindiro closed this Dec 12, 2018
@Demindiro Demindiro deleted the 368-message-reaction branch December 12, 2018 17:20
@chelsybradley15 chelsybradley15 linked an issue Mar 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants