Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stuck on upload page, because waiting for text - upload complete, and puppeter doesn't watch this, but i see this from my eyes #125

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

sacredrel1c
Copy link
Contributor

@sacredrel1c sacredrel1c commented Jul 5, 2022

changed waitting for text Upload -> Processing if skipProcessing:false, changed timeout, because timeout 0 sometimes stuck at upload page when video uploaded successfully, and add message to console.
timeout 0 it's bad variant, because it still waitting infinite.


This change is Reviewable

…lse, changed timeout, because timeout 0 sometimes stuck at upload page when video uploaded successfully, and add message to console.
@fawazahmed0
Copy link
Owner

Have you tested it for large videos (i.e 1-2GB video size) ?

@sacredrel1c
Copy link
Contributor Author

Have you tested it for large videos (i.e 1-2GB video size) ?

I'm not sure, because i use small videos (30-50mb), maybe need additional checks (i.e await another xPath, like text status in top of pop-up page) maybe I'll think about it and present better solution.

…pload-progress in bottom of pop-up, return default values of timeout.
@sacredrel1c
Copy link
Contributor Author

i analyzed previous code, and found right xPath-text to more stability. And fix processing xpath-text.

@fawazahmed0
Copy link
Owner

I will merge this after someone tests it for large videos

@saliholoji
Copy link

please merge this i have the same problem and this is the only solution

@fawazahmed0 fawazahmed0 merged commit 41ebb82 into fawazahmed0:main Jul 9, 2022
@fawazahmed0
Copy link
Owner

Thanks once again for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants