Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

videoJSON must be a object, so it need a default value {}, not undefined, or will get TypeError. #43

Closed
weizhiqimail opened this issue Oct 4, 2021 · 3 comments · Fixed by #47
Closed

videoJSON must be a object, so it need a default value {}, not undefined, or will get TypeError. #43

weizhiqimail opened this issue Oct 4, 2021 · 3 comments · Fixed by #47
Labels
Hacktoberfest

Comments

@weizhiqimail
Copy link
Contributor

youtube-uploader/upload.js

Line 317 in 116ece9

async function uploadVideo (videoJSON) {

@fawazahmed0
Copy link
Owner

You should pass an object when calling upload function, with path of video, title of video & description of video.

upload (credentials, [{ path: 'video.mp4', title: 'title 1', description: 'description 1' }]).then(console.log)

@fawazahmed0 fawazahmed0 reopened this Oct 4, 2021
@weizhiqimail
Copy link
Contributor Author

I can understand, but I personally feel that this error message should be verified by the tool and the relevant action error message, not js error, like throw a please pass upload's second param.

@fawazahmed0
Copy link
Owner

Hi @weizhiqimail , you can send a PR, I will be happy to merge it

@fawazahmed0 fawazahmed0 reopened this Oct 8, 2021
@fawazahmed0 fawazahmed0 mentioned this issue Oct 8, 2021
Merged
fawazahmed0 added a commit that referenced this issue Oct 8, 2021
@fawazahmed0
Merge pull request #47 from weizhiqimail/main
635c857 
fix ##43
crystalWeb3 pushed a commit to crystalWeb3/youtub_video_upload that referenced this issue Sep 26, 2024
@weizhiqimail
https://github.com/fawazahmed0/youtube-uploader/issues/43
91555d9
crystalWeb3 added a commit to crystalWeb3/youtub_video_upload that referenced this issue Sep 26, 2024
@crystalWeb3
Merge pull request #47 from weizhiqimail/main
de206a3 
fix #fawazahmed0/youtube-uploader#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #https://github.com/fawazahmed0/youtube-uploader/issues/43
2 participants
@fawazahmed0 @weizhiqimail