Fix dropped messages when topic backpressure is enabled (#88) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkivikram
approved these changes
Jan 29, 2021
patkivikram
added a commit
that referenced
this pull request
Jan 29, 2021
* Restore tox configuration and enable unit tests (#79) * Restore tox configuration and enable unit tests (#79) * Restore tox configuration and enable unit tests (#79) * Restore tox configuration and enable unit tests (#79) * Fix rocksdb tests * Fix dropped messages when topic backpressure is enabled (#88) (#89) * Restore tox configuration and enable unit tests (#79) * Fix rocksdb tests Co-authored-by: Vikram Patki <54442035+patkivikram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #88
Consumer.getmany() should continue to yield messages from the TopicBuffer as long as the topic is in available_partitions or buffered_partitions