Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web_ssl_context to allow internal web server to support https #69

Merged
merged 4 commits into from
Jan 4, 2021

Conversation

bobh66
Copy link
Contributor

@bobh66 bobh66 commented Dec 25, 2020

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Add the web_ssl_context configuration option to allow the web server to support https

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #69 (6b6d623) into master (e239534) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   64.03%   64.03%           
=======================================
  Files          99       99           
  Lines       10290    10290           
  Branches     1157     1157           
=======================================
  Hits         6589     6589           
  Misses       3547     3547           
  Partials      154      154           
Impacted Files Coverage Δ
faust/web/drivers/aiohttp.py 63.07% <ø> (ø)
faust/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e239534...6b6d623. Read the comment docs.

@bobh66 bobh66 marked this pull request as draft December 26, 2020 16:23
@patkivikram patkivikram marked this pull request as ready for review December 28, 2020 23:46
@patkivikram
Copy link
Collaborator

Can you please rebase this branch?

@bobh66
Copy link
Contributor Author

bobh66 commented Jan 4, 2021

@patkivikram As far as I can tell the branch is up to date with the master branch. Is there an issue I'm not seeing? Thanks

@patkivikram patkivikram merged commit fcb6b18 into faust-streaming:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants