Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loop argument from aiokafka driver #641

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

didimelli
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

When using faust, you get the following deprecation warning:

/path/to/proj/venv/.venv/lib/python3.9/site-packages/faust/transport/drivers/aiokafka.py:1244: DeprecationWarning: The loop argument is deprecated since 0.7.1, and scheduled for removal in 0.9.0
    return self._producer_type(

This pr simply removes the loop=self.loop line in aiokafka drivers.

@didimelli didimelli marked this pull request as draft August 12, 2024 15:25
Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'm surprised this didn't get removed earlier. Approved!

@didimelli didimelli marked this pull request as ready for review August 13, 2024 07:33
@didimelli
Copy link
Contributor Author

Hey @wbarnha , no problem! However I have required steps that are failing for "random" errors, like https://github.com/faust-streaming/faust/actions/runs/10354657490/job/28676223424?pr=641#step:5:30, and I cannot merge. Those does not look related to my pr though..

@wbarnha
Copy link
Member

wbarnha commented Aug 13, 2024

Hey @wbarnha , no problem! However I have required steps that are failing for "random" errors, like https://github.com/faust-streaming/faust/actions/runs/10354657490/job/28676223424?pr=641#step:5:30, and I cannot merge. Those does not look related to my pr though..

Correct, I'm working on those in a separate PR. No worries on your part!

@wbarnha wbarnha merged commit a50e525 into faust-streaming:master Aug 13, 2024
17 of 21 checks passed
@didimelli didimelli deleted the remove-loop-arg-aiokafka branch August 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants