Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix cython _on_stream_event_in call to match python impl #608

Merged

Conversation

Tim-Thomas
Copy link
Contributor

Description

Changes the cython logic around invoking _on_stream_event_in to match the logic in the python implementation.

Fixes #607

@wbarnha wbarnha self-requested a review February 15, 2024 23:08
@wbarnha wbarnha added the bug Something isn't working label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d248bf) 93.72% compared to head (15aa6a5) 93.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         102      102           
  Lines       11122    11122           
  Branches     1545     1545           
=======================================
  Hits        10424    10424           
  Misses        607      607           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbarnha
Copy link
Member

wbarnha commented Feb 15, 2024

Thanks for the PR! Just run ./scripts/lint and you should be good to go for linting.

@Tim-Thomas
Copy link
Contributor Author

Thanks for the PR! Just run ./scripts/lint and you should be good to go for linting.

Running that script changes a large number of files so I opened another PR to match. If this is an issue with my local black config or flake8, please let me know and I'll take another look. I am assuming that there was a change in black as the linting failures that appear in the CI/CD job match the changes that I saw locally when running linting.

PR here: #609

Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faust/faust/streams.py

Lines 1183 to 1191 in 6d248bf

if topic in acking_topics and not message.tracked:
message.tracked = True
# This inlines Consumer.track_message(message)
add_unacked(message)
on_message_in(message.tp, message.offset, message)
# XXX ugh this should be in the consumer somehow
# call Sensors
sensor_state = on_stream_event_in(tp, offset, self, event)

Indeed it should be, good catch!

@wbarnha wbarnha merged commit ebf66ae into faust-streaming:master Feb 16, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic around sensor _on_stream_event_in differs between cython and python implementations
2 participants