Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using aiokafka's default partition strategy when table_standy_replica… #402

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

patkivikram
Copy link
Collaborator

This should fix Issue 401

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 92.96% // Head: 94.00% // Increases project coverage by +1.04% 🎉

Coverage data is based on head (263879d) compared to base (73e4400).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   92.96%   94.00%   +1.04%     
==========================================
  Files         102      102              
  Lines       11069    11073       +4     
  Branches     1263     1257       -6     
==========================================
+ Hits        10290    10409     +119     
+ Misses        702      584     -118     
- Partials       77       80       +3     
Impacted Files Coverage Δ
faust/__init__.py 100.00% <100.00%> (ø)
faust/cli/base.py 98.20% <100.00%> (ø)
faust/models/typing.py 94.36% <100.00%> (-0.94%) ⬇️
faust/transport/drivers/aiokafka.py 74.14% <100.00%> (+0.07%) ⬆️
faust/agents/replies.py 100.00% <0.00%> (ø)
faust/livecheck/patches/aiohttp.py 100.00% <0.00%> (ø)
faust/transport/consumer.py 94.33% <0.00%> (+<0.01%) ⬆️
faust/transport/producer.py 89.16% <0.00%> (+0.09%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@patkivikram patkivikram merged commit 9aba24c into master Oct 28, 2022
@wbarnha wbarnha deleted the fix_partition branch July 3, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition Assignments are still non uniform for apps with table_standby_replicas=0
3 participants