Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmark *some* Aiokafkaconsumer thread tests #377

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

wbarnha
Copy link
Member

@wbarnha wbarnha commented Oct 6, 2022

Hopefully this will help us investigate #166.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 93.42% // Head: 94.37% // Increases project coverage by +0.95% 🎉

Coverage data is based on head (f5c7abb) compared to base (fda5c40).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   93.42%   94.37%   +0.95%     
==========================================
  Files         102      102              
  Lines       11023    11023              
  Branches     1293     1293              
==========================================
+ Hits        10298    10403     +105     
+ Misses        646      540     -106     
- Partials       79       80       +1     
Impacted Files Coverage Δ
faust/transport/drivers/aiokafka.py 74.10% <0.00%> (+15.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha
Copy link
Member Author

wbarnha commented Oct 6, 2022

Lots of woes here related to opentracing, which is now deprecated: opentracing/specification#163

@wbarnha wbarnha changed the title Fix Aiokafkaconsumer thread tests Unmark *some* Aiokafkaconsumer thread tests Oct 6, 2022
@wbarnha
Copy link
Member Author

wbarnha commented Oct 6, 2022

After further investigation, there's a lot that needs to be done for fixing opentracing usage. I think the move for now is to merge this as-is and then migrate opentracing usage over to opentelemetry as documented in https://opentelemetry-python.readthedocs.io/en/stable/shim/opentracing_shim/opentracing_shim.html.

@wbarnha wbarnha marked this pull request as ready for review October 6, 2022 16:41
@wbarnha wbarnha merged commit 0dab360 into faust-streaming:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants