Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing f prefix on f-string #337

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

russellpierce
Copy link
Contributor

Description

Clones https://github.com/robinhood/faust/pull/755/files for faust-streaming to fix robinhood/faust#754 (comment) - which I didn't create for this repo to avoid clutter for such a small fix.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #337 (982182c) into master (9ec1858) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files         100      100           
  Lines       10903    10903           
  Branches     1529     1529           
=======================================
  Hits        10295    10295           
  Misses        533      533           
  Partials       75       75           
Impacted Files Coverage Δ
faust/streams.py 96.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wbarnha
Copy link
Member

wbarnha commented Aug 10, 2022

Good catch, thanks for the PR!

@wbarnha wbarnha merged commit bd1dabb into faust-streaming:master Aug 10, 2022
@russellpierce russellpierce deleted the missing-f-string branch August 19, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing f prefix on f-strings
3 participants