Improve monitor performance #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrand
force-pushed
the
feat/performance-improvements-on-monitor
branch
from
f7345ce
to
c0e211a
Compare
cache via a weak key the str names of tasks and streams. This greatly reduces iterations as this code path takes 50% of the iteration loop on streams in the _py_aiter function.
cbrand
force-pushed
the
feat/performance-improvements-on-monitor
branch
from
c0e211a
to
5446529
Compare
|
I am a bit confused regarding the flake8 issues. It doesn't touch any of the code I changed. Also, running flake8 locally seems to not issue any of these errors for some reason. Did something change recently? |
cbrand
force-pushed
the
feat/performance-improvements-on-monitor
branch
from
c034208
to
cf92209
Compare
|
Added cf92209 fixing the flake8 issues. They have nothing to do with the changed code base so I decided to put them in an own Commit. Please verify. |
patkivikram
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache via a
WeakKeyDictionarythe str names of tasks and streams. This greatly reduces iterations as this code path takes 50% of the iteration loop on streams in the _py_aiter function in my use case.Note: Before submitting this pull request, please review our contributing
guidelines.