Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional sentry tags and arguments #285

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

ran-ka
Copy link
Contributor

@ran-ka ran-ka commented Mar 13, 2022

Description

A small change to the sentry handler to support additional tags and arguments.

Currently, you can only set up a generic sentry handler with no additional arguments and tags as described here: sentry configuration. This is a small change that exposes additional arguments such as environment, release, tags, site, etc...

Not sure why this was not supported in the first place, as it looks like this was the intention.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #285 (c120059) into master (84302f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         100      100           
  Lines       10842    10842           
  Branches     1481     1481           
=======================================
  Hits        10269    10269           
  Misses        500      500           
  Partials       73       73           
Impacted Files Coverage Δ
faust/contrib/sentry.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84302f5...c120059. Read the comment docs.

@patkivikram patkivikram merged commit c230076 into faust-streaming:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants