Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerouted HTTP requests retain the original request headers #276

Conversation

brennerd11
Copy link
Contributor

Description

When using the table_route decorator the headers of the original HTTP request issued to the initally targetted worker were lost.
Headers are now copied 1-to-1 before routing the request to the determined downstream worker

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #276 (b382c48) into master (89c1614) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         100      100           
  Lines       10830    10830           
  Branches     1478     1478           
=======================================
  Hits        10212    10212           
  Misses        548      548           
  Partials       70       70           
Impacted Files Coverage Δ
faust/app/router.py 96.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c1614...b382c48. Read the comment docs.

@patkivikram patkivikram merged commit f1df56b into faust-streaming:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants