Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flushing producer before commit #273

Merged
merged 6 commits into from
Feb 25, 2022
Merged

flushing producer before commit #273

merged 6 commits into from
Feb 25, 2022

Conversation

patkivikram
Copy link
Collaborator

flushing producer before commit to not have any data loss

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #273 (38ddee0) into master (4e32327) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         100      100           
  Lines       10829    10830    +1     
  Branches     1478     1478           
=======================================
+ Hits        10211    10212    +1     
  Misses        548      548           
  Partials       70       70           
Impacted Files Coverage Δ
faust/__init__.py 100.00% <100.00%> (ø)
faust/transport/consumer.py 94.57% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e32327...38ddee0. Read the comment docs.

@patkivikram patkivikram merged commit 28595d0 into master Feb 25, 2022
@wbarnha wbarnha deleted the flush_producer branch July 3, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants