-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Producer: Rewrite non enabled unit tests #272
Producer: Rewrite non enabled unit tests #272
Conversation
379aaaf
to
5463463
Compare
@patkivikram hopefully fixed the formatting issues (i only ran black on the faust repository and not the tests repository accidentally). |
@cbrand can you resolve the conflicts? |
Yes, will do and I will get back to you. |
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 100 100
Lines 10842 10842
Branches 1481 1481
=======================================
Hits 10269 10269
Misses 500 500
Partials 73 73 Continue to review full report at Codecov.
|
5a68732
to
4b29ac3
Compare
@patkivikram done. Please check. I also realized that it seems that the |
Description
During the implementation of #270 I realized that a couple of unit tests inside of the tests/unit/transport/test_producer.py doesn't do anything due to early return statements.
This PR adjusts all the tests to check for expected behavior which did not run correctly before.
Open Question is the
flush_atmost
function. Due to the event set wait method, it cannot be guaranteed that during the flush operation that there are at max the max_messages of sent events being sent. According to the function name and the previous test, however, this is the intended behavior.I adjusted the test accordingly and just expect that messages are sent out, as there doesn't seem to be a reasonable primitive to fulfill the existing expectation within the test.