Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deque_pushpopmax() function with deque(maxlen=) #115

Merged

Conversation

pwilczynskiclearcode
Copy link
Contributor

Description

Simplify the code by getting rid of deque_pushpopmax in favour of using maxlen= parameter of deque.
deque_pushpopmax() would be useful if we actually used its return value but we don't

@pwilczynskiclearcode pwilczynskiclearcode force-pushed the deque_pushpopmax branch 6 times, most recently from 24f6873 to 244d9fd Compare February 26, 2021 13:56
@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #115 (04bee05) into master (70e5516) will decrease coverage by 1.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   93.74%   92.56%   -1.18%     
==========================================
  Files         100      100              
  Lines       10619    10616       -3     
  Branches     1194     1189       -5     
==========================================
- Hits         9955     9827     -128     
- Misses        611      734     +123     
- Partials       53       55       +2     
Impacted Files Coverage Δ
faust/livecheck/case.py 99.62% <100.00%> (-0.01%) ⬇️
faust/sensors/monitor.py 99.64% <100.00%> (-0.01%) ⬇️
faust/windows.py 56.89% <0.00%> (-43.11%) ⬇️
faust/streams.py 77.77% <0.00%> (-21.76%) ⬇️
faust/transport/conductor.py 98.58% <0.00%> (-1.42%) ⬇️
faust/models/typing.py 94.36% <0.00%> (-0.94%) ⬇️
faust/livecheck/patches/aiohttp.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e5516...04bee05. Read the comment docs.

@patkivikram patkivikram merged commit 788f310 into faust-streaming:master Feb 27, 2021
@pwilczynskiclearcode pwilczynskiclearcode deleted the deque_pushpopmax branch March 1, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants