Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-3918] Update README to CLI v4 beta #2

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Conversation

jrodewig
Copy link
Contributor

  • Updates the README for the CLI v4 beta.
  • Adds a scripts/seed.sh script so users can add test data.
  • Updates scripts/setup.sh to use the same seed data as seed.sh.

README.md Outdated
fauna database create \
--name ECommercePython \
--database us \
--no-typechecked
Copy link
Contributor Author

@jrodewig jrodewig Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --no-typechecked isn't ideal, but hitting the GET /customers/999 endpoint results in some FQL errors without it. We can remove this once those are fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will attempt to update this PR with a fix today, if I don't have time, I'll resolve and merge it as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Throwing a bunch of optional chaining (?.) or non-null assertion (!.) operators here did the trick for this particular endpoint:

https://github.com/fauna/python-sample-app/blob/main/ecommerce_app/models/customer.py#L29-L30

May be more to do tho. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this the other day, I updated this PR with another type checking fix.

@jrodewig jrodewig requested review from findgriffin and a team December 20, 2024 15:27
@findgriffin findgriffin merged commit ed66efb into main Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants