-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-3918] Update README to CLI v4 beta #2
Conversation
README.md
Outdated
fauna database create \ | ||
--name ECommercePython \ | ||
--database us \ | ||
--no-typechecked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using --no-typechecked
isn't ideal, but hitting the GET /customers/999
endpoint results in some FQL errors without it. We can remove this once those are fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will attempt to update this PR with a fix today, if I don't have time, I'll resolve and merge it as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Throwing a bunch of optional chaining (?.
) or non-null assertion (!.
) operators here did the trick for this particular endpoint:
https://github.com/fauna/python-sample-app/blob/main/ecommerce_app/models/customer.py#L29-L30
May be more to do tho. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this the other day, I updated this PR with another type checking fix.
scripts/seed.sh
script so users can add test data.scripts/setup.sh
to use the same seed data asseed.sh
.