Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DB names in examples #541

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Improve DB names in examples #541

merged 4 commits into from
Dec 18, 2024

Conversation

jrodewig
Copy link
Contributor

Problem

This is strictly a QoL improvement. No real problem here.

  • When using fauna database create/delete, the relationship can get confusing between child and parent DBs, particularly when using a --secret.
  • Using example as the default database name is fine but it's not descriptive.

Solution

  • Where applicable, use child_db and parent_db in examples so it's more obvious.
  • Use the shorter but more descriptive my_db as the default database name. The name also indicates that underscores are supported in database names.

@jrodewig jrodewig requested a review from a team as a code owner December 17, 2024 23:56
@ecooper ecooper merged commit c4d0a50 into v3 Dec 18, 2024
4 checks passed
@ecooper ecooper deleted the better-child-exs branch December 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants