Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test --include options #536

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Test --include options #536

merged 4 commits into from
Dec 17, 2024

Conversation

ptpaterson
Copy link
Contributor

Ticket(s): FE-###

Problem

We don't have any tests exercising the --include options.

Solution

Containerize formatQueryOptions and check if it gets called with the right options.

Result

have tests.

@ptpaterson ptpaterson marked this pull request as ready for review December 17, 2024 13:38
@ptpaterson ptpaterson requested a review from a team as a code owner December 17, 2024 13:38
@ptpaterson ptpaterson changed the title Tidy query info Test query info Dec 17, 2024
@ptpaterson ptpaterson changed the title Test query info Test --include options Dec 17, 2024
echo-bravo-yahoo
echo-bravo-yahoo approved these changes Dec 17, 2024
View reviewed changes
test/query.mjs Outdated Show resolved Hide resolved
@ptpaterson ptpaterson merged commit 53c7109 into v3 Dec 17, 2024
4 checks passed
@ptpaterson ptpaterson deleted the tidy-query-info branch December 17, 2024 17:54
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwilde345 mwilde345 mwilde345 approved these changes

@echo-bravo-yahoo echo-bravo-yahoo echo-bravo-yahoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptpaterson @echo-bravo-yahoo @mwilde345