Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prefill GoRename #711

Merged
merged 1 commit into from
Feb 5, 2016
Merged

Do not prefill GoRename #711

merged 1 commit into from
Feb 5, 2016

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Feb 4, 2016

What do you think about this? Most of the time I rename something completely different.

@fatih
Copy link
Owner

fatih commented Feb 4, 2016

I think :GoRename is only prefilled if you select it. You can still always just type :GoRename foo yourself. I'm not keen to change it as this is also same for other IDE refactoring tools. But we could add a g:go_gorename_prefill = 1 option (by default on, so we don't break backwards compatibility). Then you can easily disable it.

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 4, 2016

I'll add that in. I got french class for 50 minutes. Can't have my laptop open.

@fatih
Copy link
Owner

fatih commented Feb 4, 2016

No worries, take your time ;)

Added a setting to prevent :GoRename from prefilling. Also if the to
identifer is empty, just return. This way if you run :GoRename but
decide to not rename, simply press escape.
@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 4, 2016

Done.

fatih added a commit that referenced this pull request Feb 5, 2016
@fatih fatih merged commit c487f16 into fatih:master Feb 5, 2016
@fatih
Copy link
Owner

fatih commented Feb 5, 2016

Thanks @nhooyr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants