disable g:go_autodetect_gopath by default #1461
Conversation
|
Personally, I think that the fewer tricks we play with There is the additional issue that right now So I would propose going a step further and removing the |
|
I agree that using |
|
@Carpetsmoker are you on board with merging this as is? |
Yeah, sure. It would be good to get @fatih's input on this too though. |
|
While at this, we should also remove the autodetection completely. The whole logic around godep and gb is not needed in my opionion. With |
CHANGELOG.md
Outdated
| @@ -22,6 +22,8 @@ IMPROVEMENTS: | |||
|
|
|||
| let g:go_list_type_commands = {"GoBuild": "quickfix", "GoTest": "locationlist"} | |||
|
|
|||
| * Disable `g:go_autodetect_gopath` by default [[GH-1461]](https://github.com/fatih/vim-go/pull/1461). | |||
There was a problem hiding this comment.
Can you move this up to the latest changelog? This seems to be in the old place as we released a new version.
|
lgtm after the changelog fix 👍 |
Disable g:go_autodetect_gopath by default since first class support for vendoring was enabled in Go by default a year and a half ago in Go 1.6 and most vendoring tools use it. At this point, there is a greatly reduced need to detect whether the old method used by Godep and gb is in effect.
bhcleek
force-pushed
the
gopath-autodetect-default
branch
from
f8e7620
to
2e6b847
Compare
* Remove g:go_autodetect_gopath Follow-up to #1461. Needs a bit more testing. * Put it back for gocode * Move GOPATH detection to autocmd * Fix PR feedback from Billy * unlet b:old_gopath * Add basic test * Update changelog * Hmm, forgot I already added a test for this. * Distinguish between GOPATH= and GOPATH never being set * shorter
Disable g:go_autodetect_gopath by default since first class support for
vendoring was enabled in Go by default a year and a half ago in Go 1.6
and most vendoring tools use it. At this point, there is a greatly
reduced need to detect whether the old method used by Godep and gb is in
effect.