Add support of g:go_doc_command and g:go_doc_options parameters

[nk2ge5k]

No description provided.

[arp242]

Personally I think it might be a good idea store this as a list, instead of two separate options:

g:go_doc_command = ["godoc"]

You can then set this to ["go", "doc"].

Or perhaps even store all commands as a dict, instead of many options:

g:go_commands = {
    \ "go": ["go"],
    \ "godoc": ["godoc"],
    \ "gometalinter": ["gometalinter"],
    " ..etc..   
\}

I don't know what Fatih thinks, though.

[fatih]

Yeah, a list is better. We can then join later. For go_commands I think that's something we can tackle later as it'll require a lot of work, don't want to add it now at least.

[nk2ge5k]

Sorry for delay.
I made g:go_doc_command type of list and removed g:go_doc_options. Hope its better now.

[arp242]

This removes the go#util#Shellescape() part. You should probably map that to every entry in g:go_doc_command?

(This should probably be done by the System() function, but changing that would require careful testing of all the System() invocations and may break people's configs).

[arp242]

Seems to work well in my testing, but there is a caveats with this: the go_doc_command setting is only used when invoked as :GoDoc packagename. If you use :GoDoc or K to get the documentation under the cursor, vim-go will always use gogetdoc.

It would be good to update the documentation as well, because this confused me rather a lot and it took me a trip to the source code to figure out why setting g:go_doc_command doesn't work.

Currently it reads:

Use this option to define which tool is used to godoc. By default `godoc` is
used

IMHO something like this would be better:

Command to use for |:GoDoc|; only used when it's invoked with a package
name. The `gogetdoc` command is always used when |:GoDoc| is used to get the
documentation of the identifier under the cursor.

[arp242]

Thank you @nk2ge5k.

[nk2ge5k]

Thank you