Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in import blocks #1387

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Allow comments in import blocks #1387

merged 1 commit into from
Aug 6, 2017

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Jul 26, 2017

Otherwise they won't get highlighted and folding won't work correctly if an
import block contains a comment.

e.g.:

2017-07-26-113553_508x91_scrot


2017-07-26-113721_623x239_scrot

Otherwise they won't get highlighted and folding won't work correctly if an
`import` block contains a comment.
@arp242
Copy link
Contributor Author

arp242 commented Aug 6, 2017

I think this should have been in 1.14 btw @fatih ... It fixes a reasonably visible bug in the new folding code.

@fatih
Copy link
Owner

fatih commented Aug 6, 2017

Seems like that slip away as I thought this was an addition (I've already merged your other fix). People usually use master anyway, but if you insist we can release a 1.14.1 with the fixes you think we should include :)

@fatih fatih merged commit e8e49ea into fatih:master Aug 6, 2017
@arp242 arp242 deleted the import-comments branch August 6, 2017 00:37
@arp242
Copy link
Contributor Author

arp242 commented Aug 6, 2017

What's the point of making releases if people don't use them? ;-)

Either way, I'm fine with leaving it as-is; just wanted to remind you that it would be a good idea to merge this sooner rather than later ;-)

@fatih
Copy link
Owner

fatih commented Aug 6, 2017

Right, the thing is they just update their plugin via PlugUpdate or cd into it and do a git pull origin master. Releases are great to keep things, for debugging and I think some linux distros also package vim-go. So anyway, we have it if needed. Thanks for reminding 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants