do not jump to the quickfix window when metalint #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
reviewed
May 22, 2017
autoload/go/lint.vim
Outdated
|
|
||
| " If focus changed, restore it (jump to the last window). | ||
| if l:winnr !=# winnr() | ||
| wincmd p |
There was a problem hiding this comment.
I think this is better:
exe l:winnr . "wincmd w"
Jumps to the saved windows directly
There was a problem hiding this comment.
I am not very god at VIML. So I follow your orders :)
There was a problem hiding this comment.
Yeah I've tested it. If you change it I'm going to merge it.
There was a problem hiding this comment.
ok, I will modify
There was a problem hiding this comment.
I have changed the codes, and test on my machine.
|
Thanks @jinleileiking 👍 |
fatih
pushed a commit
that referenced
this pull request
May 31, 2017
* do not jump to the quickfix window when gometalinter is executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1290
copy codes from
ale